search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.54k stars 11.8k forks source link

apt.llvm.org patch causes `warning: 'LIBCXXABI_ARM_EHABI' is not defined` #59240

Open AlexPykavy opened 1 year ago

AlexPykavy commented 1 year ago

Hi,

I've downloaded llvm-toolchain-15-15.0.6~++20221123033158+e6e61e9b2ef7 debian package from the deb-src http://apt.llvm.org/jammy/ llvm-toolchain-jammy-15 main and tried to build the libcxx and libcxxabi but encountered many warnings, like:

/tmp/llvm-toolchain-15-15.0.6/libcxxabi/src/cxa_exception.cpp:278:8: warning: 'LIBCXXABI_ARM_EHABI' is not defined, evaluates to 0 [-Wundef]
#elif !LIBCXXABI_ARM_EHABI

I've looked at the e6e61e9b2ef7 commit from the release/15.x branch in this repository and haven't found LIBCXXABI_ARM_EHABI in the cxa_exception.cpp file which seems to be deleted in the https://github.com/llvm/llvm-project/commit/71e329266adaed71eb3704d9bf5d122d2003eb85 commit.

LebedevRI commented 1 year ago

That isn't unexpected, packages routinely patch the sources.

rymiel commented 1 year ago

The relevant patch is probably this: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/15/debian/patches/libcxx/libcxxabi-arm-ehabi-fix.patch Probably just not updated