search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.31k stars 11.69k forks source link

Clang crash: Assertion `I->getParent() && "Instruction not inserted yet?"' failed. #64302

Closed shao-hua-li closed 1 year ago

shao-hua-li commented 1 year ago

Clang at -O1 would crash on the following testcase.

Compiler explorer: https://godbolt.org/z/Tezv9ecr5

% cat a.c
int a, e, f;
static int **b = &a, **c = &a;
long d;
void g() {
  int h;
  for (; h; h--)
    for (; d;)
      ;
  **b = 6;
  if (f)
  i:
    e = **c;
  goto i;
}
int main() {}
%
% clang -w -O1 a.c
clang-18: /tmp/tmpm147ngp6/tmptux1cyp_/llvm/include/llvm/Transforms/Utils/InstructionWorklist.h:60: void llvm::InstructionWorklist::push(llvm::Instruction *): Assertion `I->getParent() && "Instruction not inserted yet?"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.  Program arguments: /zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/clang-18 -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -dumpdir a- -disable-free -clear-ast-before-backend -main-file-name reduced.c -mrelocation-model pic -pic-level 2 -pic-is-pie -mframe-pointer=none -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/zdata/shaoli/realsmith/watchdir/reduced/case_CyUQUHKA -resource-dir /zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/lib/clang/18 -internal-isystem /zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/lib/clang/18/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/11/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -O1 -fdebug-compilation-dir=/zdata/shaoli/realsmith/watchdir/reduced/case_CyUQUHKA -ferror-limit 19 -fgnuc-version=4.2.1 -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/reduced-bb8a2c.o -x c reduced.c
1.  <eof> parser at end of file
2.  Optimizer
 #0 0x00007f8f0d71b637 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x87f637)
 #1 0x00007f8f0d71938e llvm::sys::RunSignalHandlers() (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x87d38e)
 #2 0x00007f8f0d71bccf SignalHandler(int) Signals.cpp:0:0
 #3 0x00007f8f1619f420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
 #4 0x00007f8f0c95300b raise (/lib/x86_64-linux-gnu/libc.so.6+0x4300b)
 #5 0x00007f8f0c932859 abort (/lib/x86_64-linux-gnu/libc.so.6+0x22859)
 #6 0x00007f8f0c932729 (/lib/x86_64-linux-gnu/libc.so.6+0x22729)
 #7 0x00007f8f0c943fd6 (/lib/x86_64-linux-gnu/libc.so.6+0x33fd6)
 #8 0x00007f8f0e825d58 llvm::InstructionWorklist::push(llvm::Instruction*) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x1989d58)
 #9 0x00007f8f0e82ae74 llvm::InstCombinerImpl::run() (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x198ee74)
#10 0x00007f8f0e82de61 combineInstructionsOverFunction(llvm::Function&, llvm::InstructionWorklist&, llvm::AAResults*, llvm::AssumptionCache&, llvm::TargetLibraryInfo&, llvm::TargetTransformInfo&, llvm::DominatorTree&, llvm::OptimizationRemarkEmitter&, llvm::BlockFrequencyInfo*, llvm::ProfileSummaryInfo*, unsigned int, bool, llvm::LoopInfo*) InstructionCombining.cpp:0:0
#11 0x00007f8f0e82d4c8 llvm::InstCombinePass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x19914c8)
#12 0x00007f8f1362f79d llvm::detail::PassModel<llvm::Function, llvm::InstCombinePass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x1d5179d)
#13 0x00007f8f0d90a3f4 llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0xa6e3f4)
#14 0x00007f8f136314fd llvm::detail::PassModel<llvm::Function, llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x1d534fd)
#15 0x00007f8f0f07ca44 llvm::CGSCCToFunctionPassAdaptor::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x21e0a44)
#16 0x00007f8f1009e52d llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::CGSCCToFunctionPassAdaptor, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x320252d)
#17 0x00007f8f0f07751e llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x21db51e)
#18 0x00007f8f0ed0e59d llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x1e7259d)
#19 0x00007f8f0f07ab48 llvm::DevirtSCCRepeatedPass::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x21deb48)
#20 0x00007f8f0ed0ebad llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::DevirtSCCRepeatedPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x1e72bad)
#21 0x00007f8f0f07957a llvm::ModuleToPostOrderCGSCCPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x21dd57a)
#22 0x00007f8f0ed0e96d llvm::detail::PassModel<llvm::Module, llvm::ModuleToPostOrderCGSCCPassAdaptor, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x1e7296d)
#23 0x00007f8f0d909074 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0xa6d074)
#24 0x00007f8f0ed0acfc llvm::ModuleInlinerWrapperPass::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x1e6ecfc)
#25 0x00007f8f1008978d llvm::detail::PassModel<llvm::Module, llvm::ModuleInlinerWrapperPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0x31ed78d)
#26 0x00007f8f0d909074 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libLLVM-18git.so+0xa6d074)
#27 0x00007f8f13628692 (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>&, std::unique_ptr<llvm::ToolOutputFile, std::default_delete<llvm::ToolOutputFile>>&) BackendUtil.cpp:0:0
#28 0x00007f8f1361f2fd clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x1d412fd)
#29 0x00007f8f13a5a90e clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x217c90e)
#30 0x00007f8f1229a484 clang::ParseAST(clang::Sema&, bool, bool) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x9bc484)
#31 0x00007f8f14695c00 clang::FrontendAction::Execute() (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x2db7c00)
#32 0x00007f8f14604fff clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x2d26fff)
#33 0x00007f8f14728c2f clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/../lib/libclang-cpp.so.18git+0x2e4ac2f)
#34 0x0000000000411866 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/clang-18+0x411866)
#35 0x000000000040e791 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&, llvm::ToolContext const&) driver.cpp:0:0
#36 0x000000000040da7a clang_main(int, char**, llvm::ToolContext const&) (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/clang-18+0x40da7a)
#37 0x000000000041d181 main (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/clang-18+0x41d181)
#38 0x00007f8f0c934083 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24083)
#39 0x000000000040ab0e _start (/zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin/clang-18+0x40ab0e)
clang: error: unable to execute command: Aborted
clang: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 18.0.0 (https://github.com/llvm/llvm-project.git aeef9c0274c6419d15df5cb2bb885aa3072423d6)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /zdata/shaoli/compilers/ccbuilder-compilers/clang-aeef9c0274c6419d15df5cb2bb885aa3072423d6/bin
clang: note: diagnostic msg:
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/reduced-9d0a71.c
clang: note: diagnostic msg: /tmp/reduced-9d0a71.sh
clang: note: diagnostic msg:

********************
%
% clang -v
clang version 18.0.0 (https://github.com/llvm/llvm-project.git e444dcef7cadb29490deca726cb743e38d0412b3)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /zdata/shaoli/compilers/ccbuilder-compilers/clang-e444dcef7cadb29490deca726cb743e38d0412b3/bin
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/10
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11
Candidate multilib: .;@m64
Selected multilib: .;@m64
%
shao-hua-li commented 1 year ago

Bisect to https://github.com/llvm/llvm-project/commit/72ec2c007e4c5f46995c8f633a946cfa43da6bfb, which was committed by @nikic

nikic commented 1 year ago

Looks like a duplicate of #64235, which is already fixed.