Open h-vetinari opened 1 year ago
Since the bot didn't tag any subscriber group here, I thought I'd do it by hand, but I actually cannot find a reasonable team for llvm overall, much less one specific to the shared libraries.
Based on the person who last touched the code referenced in the OP: @davidbolvansky, are you still working on llvm-c
?
CC @tstellar @MaskRay @keith @jh7370 (based on people who are in several tools:llvm-*
groups) perhaps you could help point me towards someone who cares about libllvm-c
on osx?
@h-vetinari, have you tried looking at the people who touch the llvm-c include folder? At a guess, those people might be able to help you, though I can't be certain.
Hello, I am not working in this area so I would not be able to help you :/
Not familiar with LLVM_BUILD_LLVM_C_DYLIB on macOS and can't help ...
Thanks for your responses @jh7370, @davidbolvansky, @MaskRay
I don't have a use-case that's directly affected, so this isn't a burning issue (I repackage things, and someone wanted libllvm-c on windows, so it made sense to me to also build it on other platforms where it is ostensibly supported).
Still, it's IMO not a great look to have an documented & selectable option that just fails to build.
As suggested by @jh7370, some more CCs based on the recent commit history of include/llvm-c
: @nikic @yamt @bogner
Based on https://github.com/llvm/llvm-project/blob/1c822e1e8278ebefdb7701249bdfe51f1ed03d7d/llvm/tools/llvm-shlib/CMakeLists.txt#L82-L85 it looks like
LLVM_BUILD_LLVM_C_DYLIB=ON
should definitely be supported on osx, however, actually setting it results in a build failure (which might be a build ordering issue, because it cannot findlibLLVM.dylib
, which definitely gets built).The stack trace below is from 17.0.0.rc2, but it has been the same for the 16.x series, and I presume it's the same for
main
. Xref also #43487.CMake invocation
``` cmake -GNinja \ -DCMAKE_INSTALL_PREFIX="${PREFIX}" \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_LIBRARY_PATH="${PREFIX}" \ -DLLVM_ENABLE_BACKTRACES=ON \ -DLLVM_ENABLE_DUMP=ON \ -DLLVM_ENABLE_LIBEDIT=OFF \ -DLLVM_ENABLE_LIBXML2=FORCE_ON \ -DLLVM_ENABLE_RTTI=ON \ -DLLVM_ENABLE_TERMINFO=OFF \ -DLLVM_ENABLE_ZLIB=FORCE_ON \ -DLLVM_ENABLE_ZSTD=FORCE_ON \ -DLLVM_DEFAULT_TARGET_TRIPLE=${HOST_TRIPLE} \ -DLLVM_HOST_TRIPLE=${HOST_TRIPLE} \ -DLLVM_INCLUDE_BENCHMARKS=OFF \ -DLLVM_INCLUDE_DOCS=OFF \ -DLLVM_INCLUDE_EXAMPLES=OFF \ -DLLVM_INCLUDE_GO_TESTS=OFF \ -DLLVM_INCLUDE_TESTS=ON \ -DLLVM_INCLUDE_UTILS=ON \ -DLLVM_INSTALL_UTILS=ON \ -DLLVM_UTILS_INSTALL_DIR=libexec/llvm \ -DLLVM_BUILD_LLVM_DYLIB=yes \ -DLLVM_LINK_LLVM_DYLIB=yes \ -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly \ -DLLVM_BUILD_LLVM_C_DYLIB=ON \ ../llvm ```