llvmbot
commented
10 months ago @llvm/issue-subscribers-orcjit
Author: None (lhames)
The current Linux atexit implementation in the ORC runtime (as of 7b83f69db4a) is:
```c++
int __orc_rt_elfnix_atexit(void (*func)(void *)) {
auto &PlatformRTState = ELFNixPlatformRuntimeState::get();
return ELFNixPlatformRuntimeState::get().registerAtExit(
func, NULL, PlatformRTState.getPlatformJDDSOHandle());
}
```
But there's no reason to assume that `func` is in the `Platform` JITDylib, the common case is that it will not be (now that both `LLJIT` and the `llvm-jitlink` tool place the ORC runtime code in a separate JITDylib from the "main" code by default).
A better implementation would be:
```c++
int __orc_rt_elfnix_atexit(void (*func)(void *)) {
auto &PlatformRTState = ELFNixPlatformRuntimeState::get();
Dl_info Info;
if (!dladdr(func, &Info))
return -1; // Could not identify address. Error out.
return ELFNixPlatformRuntimeState::get().registerAtExit(
func, NULL, Info.dli_fbase);
}
```
but we'll need a JIT `dladdr` implementation before we can do that.
lhames
The current ELF atexit implementation in the ORC runtime (as of 7b83f69db4a) is:
But there's no reason to assume that
funcis in thePlatformJITDylib, the common case is that it will not be (now that bothLLJITand thellvm-jitlinktool place the ORC runtime code in a separate JITDylib from the "main" code by default).A better implementation would be:
but we'll need a JIT
dladdrimplementation before we can do that.