[Driver][Darwin] Move the remaining bits for header path handling over to the Driver.

[brad0]

The remaining bits for the header path handling need to be moved over to the Driver within AddClangSystemIncludeArgs() as has been done for other OS's to date.

clang/lib/Lex/InitHeaderSearch.cpp

https://github.com/llvm/llvm-project/blob/7113c80289d62de95bca818109324601a51fefd8/clang/lib/Lex/InitHeaderSearch.cpp#L343

  // NOTE: some additional header search logic is handled in the driver for
  // Darwin.
  if (triple.isOSDarwin()) {
    if (HSOpts.UseStandardSystemIncludes) {
      // Add the default framework include paths on Darwin.
      if (triple.isDriverKit()) {
        AddPath("/System/DriverKit/System/Library/Frameworks", System, true);
      } else {
        AddPath("/System/Library/Frameworks", System, true);
        AddPath("/Library/Frameworks", System, true);
      }
    }
    return;
  }

[llvmbot]

@llvm/issue-subscribers-clang-driver

Author: Brad Smith (brad0)

The remaining bits for the header path handling need to be moved over to the Driver within AddClangSystemIncludeArgs() as has been done for other OS's to date. clang/lib/Lex/InitHeaderSearch.cpp https://github.com/llvm/llvm-project/blob/7113c80289d62de95bca818109324601a51fefd8/clang/lib/Lex/InitHeaderSearch.cpp#L343 ``` // NOTE: some additional header search logic is handled in the driver for // Darwin. if (triple.isOSDarwin()) { if (HSOpts.UseStandardSystemIncludes) { // Add the default framework include paths on Darwin. if (triple.isDriverKit()) { AddPath("/System/DriverKit/System/Library/Frameworks", System, true); } else { AddPath("/System/Library/Frameworks", System, true); AddPath("/Library/Frameworks", System, true); } } return; } ```

[MaskRay]

@jansvoboda11 @jroelofs

https://reviews.llvm.org/D158376 (DragonFlyBSD) is a migration example.

[brad0]

@MaskRay I had spoken to jroelofs on Discourse and he said to file an issue so he could pass it around to someone appropriate at Apple.

[jroelofs]

cc: @ldionne @cachemeifyoucan

[ldionne]

Reverted in https://github.com/llvm/llvm-project/commit/d34901f30b8b7ac8fe1437eeb588da6805b27cfb due to LSan issues.