[Flang] Compilation of a derived type which has many members of other derived types needs a lot of time

[yus3710-fj]

This is an issue from Fujitsu testsuite.

Flang-new needs a lot of time to compile the following code. (The compilation command is executed with ulimit -t 300 in Fujitsu testsuite.)

The following are the test program, the result of time command of flang-new and gfortran compilation.

! test.f90
   type x00a
     integer::x00a000
     type(x00e),pointer::x00e110
   end type
   type x00b
     type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,&
                         x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,&
                         x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,&
                         x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,&
                         x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159
     type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009
     type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009
     type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009
     type(x00d),pointer::x00e000,x00e001,x00e002,x00e003,x00e004,x00e005,x00e006,x00e007,x00e008,x00e009,&
                         x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,&
                         x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,&
                         x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,&
                         x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,&
                         x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059
   end type
   type x00c
     type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,&
                         x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,&
                         x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,&
                         x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,&
                         x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159
     type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009
     type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009
     type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009
     type(x00d),pointer::x00e000,x00e001,x00e002,x00e003,x00e004,x00e005,x00e006,x00e007,x00e008,x00e009,&
                         x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,&
                         x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,&
                         x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,&
                         x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,&
                         x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059
   end type
   type x00d
     type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,&
                         x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,&
                         x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,&
                         x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,&
                         x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159
     type(x00d),pointer::x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,&
                         x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,&
                         x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,&
                         x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,&
                         x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059
     type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009
     type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009
     type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009
   end type
   type x00e
     type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,&
                         x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,&
                         x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,&
                         x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,&
                         x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159
     type(x00d),pointer::x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,&
                         x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,&
                         x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,&
                         x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,&
                         x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059
     type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009
     type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009
     type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009
   end type

type(x00a),pointer::p0a
end

$ time flang-new -v test.f90
flang-new version 18.0.0git (https://github.com/llvm/llvm-project.git 0e07bf91f7e3d5a53f0a51309da12e91ea8accc9)
Target: aarch64-unknown-linux-gnu
Thread model: posix
InstalledDir: /path/to/install/bin
Found candidate GCC installation: /opt/rh/gcc-toolset-12/root/usr/lib/gcc/aarch64-redhat-linux/12
Selected GCC installation: /opt/rh/gcc-toolset-12/root/usr/lib/gcc/aarch64-redhat-linux/12
Candidate multilib: .;@m64
Selected multilib: .;@m64
 "/path/to/install/bin/flang-new" -fc1 -triple aarch64-unknown-linux-gnu -emit-obj -fcolor-diagnostics -mrelocation-model pic -pic-level 2 -pic-is-pie -target-cpu generic -target-feature +neon -target-feature +v8a -mframe-pointer=non-leaf -o test.o -x f95-cpp-input test.f90

real    5m35.269s
user    1m7.805s
sys     4m22.249s

$ time gfortran -v test.f90
Driving: gfortran -v test.f90 -l gfortran -l m -shared-libgcc
Using built-in specs.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/aarch64-redhat-linux/8/lto-wrapper
Target: aarch64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl --disable-libmpx --enable-gnu-indirect-function --build=aarch64-redhat-linux
Thread model: posix
gcc version 8.5.0 20210514 (Red Hat 8.5.0-18) (GCC)
 :

real    0m0.144s
user    0m0.082s
sys     0m0.028s

[llvmbot]

@llvm/issue-subscribers-flang-frontend

Author: Yusuke MINATO (yus3710-fj)

This is an issue from Fujitsu testsuite. Flang-new needs a lot of time to compile the following code. (The compilation command is executed with `ulimit -t 300` in Fujitsu testsuite.) The following are the test program, the result of `time` command of flang-new and gfortran compilation. ```fortran ! test.f90 type x00a integer::x00a000 type(x00e),pointer::x00e110 end type type x00b type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00d),pointer::x00e000,x00e001,x00e002,x00e003,x00e004,x00e005,x00e006,x00e007,x00e008,x00e009,& x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 end type type x00c type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00d),pointer::x00e000,x00e001,x00e002,x00e003,x00e004,x00e005,x00e006,x00e007,x00e008,x00e009,& x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 end type type x00d type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00d),pointer::x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 end type type x00e type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00d),pointer::x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 end type type(x00a),pointer::p0a end ``` ```console $ time flang-new -v test.f90 flang-new version 18.0.0git (https://github.com/llvm/llvm-project.git 0e07bf91f7e3d5a53f0a51309da12e91ea8accc9) Target: aarch64-unknown-linux-gnu Thread model: posix InstalledDir: /path/to/install/bin Found candidate GCC installation: /opt/rh/gcc-toolset-12/root/usr/lib/gcc/aarch64-redhat-linux/12 Selected GCC installation: /opt/rh/gcc-toolset-12/root/usr/lib/gcc/aarch64-redhat-linux/12 Candidate multilib: .;@m64 Selected multilib: .;@m64 "/path/to/install/bin/flang-new" -fc1 -triple aarch64-unknown-linux-gnu -emit-obj -fcolor-diagnostics -mrelocation-model pic -pic-level 2 -pic-is-pie -target-cpu generic -target-feature +neon -target-feature +v8a -mframe-pointer=non-leaf -o test.o -x f95-cpp-input test.f90 real 5m35.269s user 1m7.805s sys 4m22.249s ``` ```console $ time gfortran -v test.f90 Driving: gfortran -v test.f90 -l gfortran -l m -shared-libgcc Using built-in specs. COLLECT_GCC=gfortran COLLECT_LTO_WRAPPER=/usr/libexec/gcc/aarch64-redhat-linux/8/lto-wrapper Target: aarch64-redhat-linux Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl --disable-libmpx --enable-gnu-indirect-function --build=aarch64-redhat-linux Thread model: posix gcc version 8.5.0 20210514 (Red Hat 8.5.0-18) (GCC) : real 0m0.144s user 0m0.082s sys 0m0.028s ```

[klausler]

I don't know what's consuming all the compilation time here, but it's after parsing & semantics.

[yus3710-fj]

Thank you for confirming, and I apologize for a lack of information. Lowering to HLFIR seems to take time. (I don't know why it takes longer time than the whole compilation...)

$ time flang-new -fc1 -fdebug-dump-pft test.f90 
1 Program <anonymous>
  1 EndProgramStmt: end
End Program <anonymous>

real    0m1.228s
user    0m0.899s
sys     0m0.209s
$ time flang-new -fc1 -emit-hlfir test.f90 
^C

real    12m49.368s
user    8m16.295s
sys     4m31.673s

[ceseo]

@yus3710-fj it's taking a lot of time because it generates about 5.5GB of HLFIR data. Most of this time is writing to disk.

@klausler I ran a profile on the compiler and it seems most of the time is spent in getAbstractType(), but that doesn't make much sense to me.

[ceseo]

Weirdly, this is not reproducible on Graviton 3, nor Apple M3. I can see this issue on x86_64 (10th gen Intel i7) and on Neoverse N1.

[clementval]

@jeanPerier did some improvement in this area.

https://github.com/llvm/llvm-project/pull/80179

[ceseo]

This is probably not a bug. I'm guessing his compiler is built as Debug. The extra time in compilation is an assert in getAbstractType(). I can't reproduce this in a Release or ReleaseWithDebInfo build.

@yus3710-fj could you please confirm your compiler comes from Debug build?

[jeanPerier]

End to end, the compilation takes 1.3 seconds for me (interestingly, most of the time was spent in the BoxedProcedurePass (0.7s) according to MLIR timers, then FIRToLLVMLowering (0.15s), then the initial lowering from parse tree to MLIR (0.05s).

However, if any FIR is printed to a temporary file, it takes forever. I concur that the FIR assembly is too big (-emit-fir takes 4m51 and indeed produce a 5Gb file).

The reason for that is mainly the lack of type aliasing in the FIR assembly. The derived types are very, very long to print because FIR spells out all the members when printing a type. Sadly, the current MLIR aliasing won't help a lot currently for this case because it currently does not allow the usage of alias when defining another type alias (at least recursively). This implies x00b has to be "unrolled" in FIR assembly at least once when defining its alias, and printing !_QFTx00b_ = !fir.type<_QFTx00b{..... once generates 1.4Gb line..... So with a draft that I have enabling MLIR assembly aliasing interface for FIR, it still takes 3mins to print the FIR output that is still 3.5Gb.

[ceseo]

@jeanPerier when I try this using a Release build, I see the same as you (~1s build and the same overhead profile)

Overhead  Command         Shared Object                              Symbol
  23.41%  flang-new       libFIRCodeGen.so.19.0git                   [.] (anonymous namespace)::BoxprocTypeRewriter::needsConversion(mlir::Type)                                                                                                                                                                                              ◆
   7.52%  flang-new       ld-linux-x86-64.so.2                       [.] do_lookup_x                                                                                                                                                                                                                                                          ▒
   5.32%  flang-new       ld-linux-x86-64.so.2                       [.] strcmp                                                                                                                                                                                                                                                               ▒
   3.70%  flang-new       libFIRDialect.so.19.0git                   [.] fir::BaseBoxType::getEleTy() const

However, in a Debug build, it's slightly different because of all the asserts:

   2.48%  flang-new       libFortranLower.so.19.0git                    [.] mlir::TypeStorage::getAbstractType()                                                                                                                                                                                                                              ◆
   1.92%  flang-new       libFIRCodeGen.so.19.0git                      [.] (anonymous namespace)::BoxprocTypeRewriter::needsConversion(mlir::Type)                                                                                                                                                                                           ▒
   1.76%  flang-new       libFortranLower.so.19.0git                    [.] mlir::SelfOwningTypeID::getTypeID() const                                                                                                                                                                                                                         ▒
   1.70%  flang-new       libFortranLower.so.19.0git                    [.] mlir::AbstractType::getTypeID() const                                                                                                                                                                                                                             ▒
   1.69%  flang-new       libFortranLower.so.19.0git                    [.] mlir::Type::getTypeID()                                                                                                                                                                                                                                           ▒
   1.61%  flang-new       libFIRDialect.so.19.0git                      [.] std::_Optional_base_impl<mlir::Type, std::_Optional_base<mlir::Type, true, true> >::_M_is_engaged() const

and the compile time is the 5m originally reported.

I think there are two separate issues here. One is the type unrolling you mentioned, another is the compilation time, which IMO, is not a bug if it's a Debug build.

[yus3710-fj]

@ceseo I apologize for my late reply. My compiler is a Release build and the compilation finishes within 20 seconds now.

$ time flang-new -v test.f90 
flang-new version 19.0.0git (https://github.com/llvm/llvm-project.git 8f878c501886e6dc8b0cf062320a803593972bed)
 :

real    0m17.664s
user    0m9.545s
sys     0m1.413s

Actually, the original code is larger than the above one and the compilation of it still takes a long time. The following is a new reproducer.

$ diff -u test.f90 test2.f90 
--- test.f90        2024-03-21 10:08:37.000000000 +0900
+++ test2.f90        2024-03-21 10:07:42.000000000 +0900
@@ -66,6 +66,16 @@
      type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009
    end type

-type(x00a),pointer::p0a
+  type(x00a),pointer::p0a,p1a,p2a,p3a,p4a,p5a,p6a,p7a,p8a,p9a,paa
+  type(x00b),pointer::p0b,p1b,p2b,p3b,p4b,p5b,p6b,p7b,p8b,p9b,pab
+  type(x00c),pointer::p0c,p1c,p2c,p3c,p4c,p5c,p6c,p7c,p8c,p9c,pac
+  type(x00d),pointer::p0d,p1d,p2d,p3d,p4d,p5d,p6d,p7d,p8d,p9d,pad
+  type(x00e),pointer::p0e,p1e,p2e,p3e,p4e,p5e,p6e,p7e,p8e,p9e,pae
+  allocate( &
+    p0a,p1a,p2a,p3a,p4a,p5a,p6a,p7a,p8a,p9a,paa,&
+    p0b,p1b,p2b,p3b,p4b,p5b,p6b,p7b,p8b,p9b,pab,&
+    p0c,p1c,p2c,p3c,p4c,p5c,p6c,p7c,p8c,p9c,pac,&
+    p0d,p1d,p2d,p3d,p4d,p5d,p6d,p7d,p8d,p9d,pad,&
+    p0e,p1e,p2e,p3e,p4e,p5e,p6e,p7e,p8e,p9e,pae)
 end

$ time flang-new test2.f90 

real    10m1.000s
user    9m49.647s
sys     0m1.967s

[jeanPerier]

Actually, the original code is larger than the above one and the compilation of it still takes a long time.

Thanks for this reproducer! It is clear in this one that the time is spent in the BoxedProcedure pass. It took 2 minutes for me.

I was able to speed-it up this use case to a couple seconds: https://github.com/llvm/llvm-project/pull/86144

I will check that this change does not affect compilation time performance on bigger apps. I am also not sure that this is causing the debug builds slowness on the first example.

[ceseo]

With the new reproducer, I see a lot of time spent in memset:

Overhead  Command         Shared Object            Symbol
  12.27%  flang-new       [kernel.kallsyms]        [k] memset_orig                                                                                                                                                                                                                                                                            ◆
   4.71%  flang-new       flang-new                [.] mlir::StorageUniquer::getParametricStorageTypeImpl(mlir::TypeID, unsigned int, llvm::function_ref<bool (mlir::StorageUniquer::BaseStorage const*)>, llvm::function_ref<mlir::StorageUniquer::BaseStorage* (mlir::StorageUniquer::StorageAllocator&)>)                                  ▒
   3.43%  flang-new       [kernel.kallsyms]        [k] link_path_walk.part.0.constprop.0                                                                                                                                                                                                                                                      ▒
   3.23%  flang-new       flang-new                [.] llvm::StringRef::find_first_of(llvm::StringRef, unsigned long) const                                                                                                                                                                                                                   ▒
   2.66%  flang-new       flang-new                [.] llvm::sys::path::remove_dots(llvm::SmallVectorImpl<char>&, bool, llvm::sys::path::Style)                                                                                                                                                                                               ▒
   2.42%  flang-new       flang-new                [.] llvm::SmallVectorImpl<char>::swap(llvm::SmallVectorImpl<char>&)                                                                                                                                                                                                                        ▒
   2.37%  flang-new       flang-new                [.] (anonymous namespace)::BoxprocTypeRewriter::needsConversion(mlir::Type)

[ceseo]

I will check that this change does not affect compilation time performance on bigger apps. I am also not sure that this is causing the debug builds slowness on the first example.

I'm 100% sure now that the Debug builds slowdown is due to the asserts. We can safely ignore that.

[ceseo]

Fixed by #86144

[llvmbot]

@llvm/issue-subscribers-flang-ir

Author: Yusuke MINATO (yus3710-fj)

This is an issue from Fujitsu testsuite. Flang-new needs a lot of time to compile the following code. (The compilation command is executed with `ulimit -t 300` in Fujitsu testsuite.) The following are the test program, the result of `time` command of flang-new and gfortran compilation. ```fortran ! test.f90 type x00a integer::x00a000 type(x00e),pointer::x00e110 end type type x00b type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00d),pointer::x00e000,x00e001,x00e002,x00e003,x00e004,x00e005,x00e006,x00e007,x00e008,x00e009,& x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 end type type x00c type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00d),pointer::x00e000,x00e001,x00e002,x00e003,x00e004,x00e005,x00e006,x00e007,x00e008,x00e009,& x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 end type type x00d type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00d),pointer::x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 end type type x00e type(x00e),pointer::x00e110,x00e111,x00e112,x00e113,x00e114,x00e115,x00e116,x00e117,x00e118,x00e119,& x00e120,x00e121,x00e122,x00e123,x00e124,x00e125,x00e126,x00e127,x00e128,x00e129,& x00e130,x00e131,x00e132,x00e133,x00e134,x00e135,x00e136,x00e137,x00e138,x00e139,& x00e140,x00e141,x00e142,x00e143,x00e144,x00e145,x00e146,x00e147,x00e148,x00e149,& x00e150,x00e151,x00e152,x00e153,x00e154,x00e155,x00e156,x00e157,x00e158,x00e159 type(x00d),pointer::x00e010,x00e011,x00e012,x00e013,x00e014,x00e015,x00e016,x00e017,x00e018,x00e019,& x00e020,x00e021,x00e022,x00e023,x00e024,x00e025,x00e026,x00e027,x00e028,x00e029,& x00e030,x00e031,x00e032,x00e033,x00e034,x00e035,x00e036,x00e037,x00e038,x00e039,& x00e040,x00e041,x00e042,x00e043,x00e044,x00e045,x00e046,x00e047,x00e048,x00e049,& x00e050,x00e051,x00e052,x00e053,x00e054,x00e055,x00e056,x00e057,x00e058,x00e059 type(x00c),pointer::x00d000,x00d001,x00d002,x00d003,x00d004,x00d005,x00d006,x00d007,x00d008,x00d009 type(x00b),pointer::x00c000,x00c001,x00c002,x00c003,x00c004,x00c005,x00c006,x00c007,x00c008,x00c009 type(x00a),pointer::x00b000,x00b001,x00b002,x00b003,x00b004,x00b005,x00b006,x00b007,x00b008,x00b009 end type type(x00a),pointer::p0a end ``` ```console $ time flang-new -v test.f90 flang-new version 18.0.0git (https://github.com/llvm/llvm-project.git 0e07bf91f7e3d5a53f0a51309da12e91ea8accc9) Target: aarch64-unknown-linux-gnu Thread model: posix InstalledDir: /path/to/install/bin Found candidate GCC installation: /opt/rh/gcc-toolset-12/root/usr/lib/gcc/aarch64-redhat-linux/12 Selected GCC installation: /opt/rh/gcc-toolset-12/root/usr/lib/gcc/aarch64-redhat-linux/12 Candidate multilib: .;@m64 Selected multilib: .;@m64 "/path/to/install/bin/flang-new" -fc1 -triple aarch64-unknown-linux-gnu -emit-obj -fcolor-diagnostics -mrelocation-model pic -pic-level 2 -pic-is-pie -target-cpu generic -target-feature +neon -target-feature +v8a -mframe-pointer=non-leaf -o test.o -x f95-cpp-input test.f90 real 5m35.269s user 1m7.805s sys 4m22.249s ``` ```console $ time gfortran -v test.f90 Driving: gfortran -v test.f90 -l gfortran -l m -shared-libgcc Using built-in specs. COLLECT_GCC=gfortran COLLECT_LTO_WRAPPER=/usr/libexec/gcc/aarch64-redhat-linux/8/lto-wrapper Target: aarch64-redhat-linux Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl --disable-libmpx --enable-gnu-indirect-function --build=aarch64-redhat-linux Thread model: posix gcc version 8.5.0 20210514 (Red Hat 8.5.0-18) (GCC) : real 0m0.144s user 0m0.082s sys 0m0.028s ```