Open Zitrax opened 9 months ago
@llvm/issue-subscribers-clang-include-cleaner
Author: Daniel Bengtsson (Zitrax)
strsignal() is POSIX, not standard C, right?
Is
All this is my way of saying, I think in this case you want
I think you are right about that.
Still it would be nice if these two checks could co-exist without littering the code with suppressions. cstring
includes string.h
directly without any protection.
I have not found any way to fix code like this without suppressing with
NOLINT
or similar.The warning from
modernize-deprecated-headers
makes sense but shouldn'tmisc-include-headers
allow using the modern C++ headers likecstring
here without warning?Godbolt example: https://godbolt.org/z/5TxEvK3P6
Tested with clang-tidy 17.0.6 and 18.0.0