llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.69k stars 11.86k forks source link

LLVM_ENABLE_RUNTIMES='all' doesn't include compiler-rt;libc;openmp #80406

Open choikwa opened 8 months ago

choikwa commented 8 months ago

https://discourse.llvm.org/t/libclang-rt-builtins-a-is-not-being-built/72862

4-rodrigo-salazar commented 8 months ago

The documentation mentioning the definition of 'all' (https://llvm.org/docs/CMake.html#options-and-variables) says the following

LLVM_ENABLE_RUNTIMES:STRING
Build libc++, libc++abi, libunwind or compiler-rt using the just-built compiler. This is the correct way to build runtimes when putting together a toolchain. It will build the builtins separately from the other runtimes to preserve correct dependency ordering. If you want to build the runtimes using a system compiler, see the [libc++ documentation](https://libcxx.llvm.org/BuildingLibcxx.html). **Note: the list should not have duplicates with LLVM_ENABLE_PROJECTS. The full list is: compiler-rt;libc;libcxx;libcxxabi;libunwind;openmp To enable all of them, use: LLVM_ENABLE_RUNTIMES=all**

Looks like this got stale with https://reviews.llvm.org/D132479 and it'll be correct to just update this documentation to describe the new intent (that it's the runtimes intended to be used if you're using LLVM_ENABLE_PROJECTS=all)

y2361547758 commented 2 weeks ago

This bothers me too. This change since LLVM16 and the document never update.