bugprone-unchecked-optional-access false positive

[alexolog]

Code:

    if (auto error = checkMsg(msg, fieldMask, {}); error.has_value())
        throw std::runtime_error(*error);

Diagnostic:

protobuf_validation.h:69:35: warning: unchecked access to optional value [bugprone-unchecked-optional-access]
   69 |         throw std::runtime_error(*error);
      |                                   ^

LLVM 17.0.6 on Mac.

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Alex (alexolog)

Code: ``` if (auto error = checkMsg(msg, fieldMask, {}); error.has_value()) throw std::runtime_error(*error); ``` Diagnostic: ``` protobuf_validation.h:69:35: warning: unchecked access to optional value [bugprone-unchecked-optional-access] 69 | throw std::runtime_error(*error); | ^ ``` LLVM 17.0.6 on Mac.

[EugeneZelenko]

Could you please try 18 or main branch?

[alexolog]

Could you please try 18 or main branch?

As soon as it gets on homebrew :)

[chrchr-github]

Does not immediately repro with trunk: https://godbolt.org/z/qobYKv1zn