search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.61k stars 11.83k forks source link

[mlir] Missing cmake dependencies from MLIRTargetLLVMIRExport to OMP generated file #88782

Open mikeurbach opened 6 months ago

mikeurbach commented 6 months ago

I noticed a periodic CI job over in CIRCT failed: https://github.com/llvm/circt/actions/runs/8688703268/job/23824907413#step:6:3287

Running ninja -t missingdeps seems to confirm this:

Missing dep: tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/LoopAnnotationTranslation.cpp.o uses /build/sifive/asan/include/llvm/Frontend/OpenMP/OMP.h.inc (generated by CUSTOM_COMMAND)
Missing dep: tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/ModuleTranslation.cpp.o uses /build/sifive/asan/include/llvm/Frontend/OpenMP/OMP.h.inc (generated by CUSTOM_COMMAND)
Missing dep: tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/Dialect/OpenMPCommon.cpp.o uses /build/sifive/asan/include/llvm/Frontend/OpenMP/OMP.h.inc (generated by CUSTOM_COMMAND)

I'm not sure if this is recently changed, or it has just been lingering for a while and we got unlucky recently. It seems like something needs to be depending on omp_gen, but I'm not sure if that belongs on the MLIRTargetLLVMIRExport target or somewhere down its transitive dependencies. I can send a patch to add the dependency somewhere, but if anyone who is more familiar with this has any ideas, I'm all ears.

llvmbot commented 6 months ago

@llvm/issue-subscribers-mlir

Author: Mike Urbach (mikeurbach)

I noticed a periodic CI job over in CIRCT failed: https://github.com/llvm/circt/actions/runs/8688703268/job/23824907413#step:6:3287 Running `ninja -t missingdeps` seems to confirm this: ``` Missing dep: tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/LoopAnnotationTranslation.cpp.o uses /build/sifive/asan/include/llvm/Frontend/OpenMP/OMP.h.inc (generated by CUSTOM_COMMAND) Missing dep: tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/ModuleTranslation.cpp.o uses /build/sifive/asan/include/llvm/Frontend/OpenMP/OMP.h.inc (generated by CUSTOM_COMMAND) Missing dep: tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRExport.dir/Dialect/OpenMPCommon.cpp.o uses /build/sifive/asan/include/llvm/Frontend/OpenMP/OMP.h.inc (generated by CUSTOM_COMMAND) ``` I'm not sure if this is recently changed, or it has just been lingering for a while and we got unlucky recently. It seems like something needs to be depending on `omp_gen`, but I'm not sure if that belongs on the MLIRTargetLLVMIRExport target or somewhere down its transitive dependencies. I can send a patch to add the dependency somewhere, but if anyone who is more familiar with this has any ideas, I'm all ears.