search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
25.94k stars 10.58k forks source link

Avoid unusable variable in ByteCodeExprGen.cpp #90469

Closed dklimkin closed 2 weeks ago

dklimkin commented 2 weeks ago

Inline assert to avoid unusable variable warning/error when asserts are disabled.

llvmbot commented 2 weeks ago

@llvm/pr-subscribers-clang

Author: Danial Klimkin (dklimkin)

Changes Inline assert to avoid unusable variable warning/error when asserts are disabled. --- Full diff: https://github.com/llvm/llvm-project/pull/90469.diff 1 Files Affected: - (modified) clang/lib/AST/Interp/ByteCodeExprGen.cpp (+1-2) ``````````diff diff --git a/clang/lib/AST/Interp/ByteCodeExprGen.cpp b/clang/lib/AST/Interp/ByteCodeExprGen.cpp index 626c30157b228f..568a929c6a1693 100644 --- a/clang/lib/AST/Interp/ByteCodeExprGen.cpp +++ b/clang/lib/AST/Interp/ByteCodeExprGen.cpp @@ -2363,8 +2363,7 @@ bool ByteCodeExprGen::VisitCXXUuidofExpr(const CXXUuidofExpr *E) { if (!this->emitGetPtrGlobal(*GlobalIndex, E)) return false; - const Record *R = this->getRecord(E->getType()); - assert(R); + assert(this->getRecord(E->getType())); const APValue &V = E->getGuidDecl()->getAsAPValue(); if (V.getKind() == APValue::None) ``````````