search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.78k stars 11.9k forks source link

[lldb][Windows] Disable the TestGdbRemoteLibrariesSvr4Support test for Windows host #92341

Closed slydiman closed 5 months ago

slydiman commented 5 months ago

Windows does not allow quotes in file names. So it is impossible to build libsvr4lib_b".so on Windows.

llvmbot commented 5 months ago

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes Windows does not allow quotes in file names. So it is impossible to build `libsvr4lib_b".so` on Windows. --- Full diff: https://github.com/llvm/llvm-project/pull/92341.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py (+2) ``````````diff diff --git a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py index 846adade34402..02c9d318525fb 100644 --- a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py +++ b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py @@ -4,6 +4,8 @@ from lldbsuite.test.lldbtest import * +# Windows does not allow quotes in file names. +@skipIf(hostoslist=["windows"]) class TestGdbRemoteLibrariesSvr4Support(gdbremote_testcase.GdbRemoteTestCaseBase): FEATURE_NAME = "qXfer:libraries-svr4:read" ``````````