Open nickdesaulniers opened 1 week ago
Hi!
This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
test/
create fine-grained testing targets, so you can e.g. use make check-clang-ast
to only run Clang's AST tests.git clang-format HEAD~1
to format your changes.If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.
@llvm/issue-subscribers-good-first-issue
Author: Nick Desaulniers (paternity leave) (nickdesaulniers)
@llvm/issue-subscribers-libc
Author: Nick Desaulniers (paternity leave) (nickdesaulniers)
https://android-review.googlesource.com/c/platform/bionic/+/3141226/1/tests/math_test.cpp also has a list of other type generic macros we should provide+test.
fpclassify, signbit, isfinite, isinf, isnan, isnormal, isgreater, isgreaterequal, isless, islessequal, islessgreater, and isunordered.
I'd like to work on this.
Hello, I want to work in this issue... Is someone working in this issue now? ._.
https://android-review.googlesource.com/c/platform/bionic/+/3141224/1/libc/include/math.h demonstrates that
__builtin_signbit
can be used to implement this macro (or a few fallbacks in case this builtin isn't available). We should use godbolt.org to figure out what compilers and compiler versions support this macro.I would put these in libc/include/llvm-libc-macros/math-macros.h (there's a comment at the bottom to start a new header for these).
It seems that we don't have tests for
isfinite
,isinf
, orisnan
macros from our math.h, which is problematic. We should start a new "include" test under libc/test/include (similar to stdbit_test.cpp).cc @lntue