search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
26.8k stars 10.98k forks source link

libc: enable -Wunused #96689

Open nickdesaulniers opened 1 week ago

nickdesaulniers commented 1 week ago

via https://github.com/llvm/llvm-project/pull/96591#discussion_r1653050200 it seems like we don't have -Wunused set.

We should enable it and clean up the instances it finds.

We should append that to compile_options in libc/cmake/modules/LLVMLibCObjectRules.cmake.

llvmbot commented 1 week ago

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

llvmbot commented 1 week ago

@llvm/issue-subscribers-good-first-issue

Author: Nick Desaulniers (paternity leave) (nickdesaulniers)

via https://github.com/llvm/llvm-project/pull/96591#discussion_r1653050200 it seems like we don't have `-Wunused` set. We should enable it and clean up the instances it finds. We should append that to `compile_options` in libc/cmake/modules/LLVMLibCObjectRules.cmake.
llvmbot commented 1 week ago

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (paternity leave) (nickdesaulniers)

via https://github.com/llvm/llvm-project/pull/96591#discussion_r1653050200 it seems like we don't have `-Wunused` set. We should enable it and clean up the instances it finds. We should append that to `compile_options` in libc/cmake/modules/LLVMLibCObjectRules.cmake.