search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
27.84k stars 11.47k forks source link

[mlir][spirv] Serializer produces incorrect generator metadata in SPIR-V header #99071

Closed andfau-amd closed 2 weeks ago

andfau-amd commented 1 month ago

See https://github.com/KhronosGroup/SPIRV-Tools/issues/5717 for more. Probably a trivial one-line fix, good low-hanging fruit for a newcomer?

andfau-amd commented 1 month ago

https://github.com/llvm/llvm-project/blob/bbcb3d6aabef60c2dd2c32764ca4fd297782c322/mlir/lib/Target/SPIRV/SPIRVBinaryUtils.cpp#L38-L57

andfau-amd commented 1 month ago

https://github.com/KhronosGroup/SPIRV-Headers/blob/3c355ec439dcf821c50fb4660ef0e50d19ae2b63/include/spirv/spir-v.xml#L35-L50

llvmbot commented 1 month ago

@llvm/issue-subscribers-mlir-spirv

Author: Andrea 🦈 (andfau-amd)

See https://github.com/KhronosGroup/SPIRV-Tools/issues/5717 for more. Probably a trivial one-line fix, good low-hanging fruit for a newcomer?
kuhar commented 1 month ago

Nice catch @andfau-amd!

llvmbot commented 1 month ago

@llvm/issue-subscribers-bug

Author: Andrea 🦈 (andfau-amd)

See https://github.com/KhronosGroup/SPIRV-Tools/issues/5717 for more. Probably a trivial one-line fix, good low-hanging fruit for a newcomer?
llvmbot commented 1 month ago

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

llvmbot commented 1 month ago

@llvm/issue-subscribers-good-first-issue

Author: Andrea Faulds (andfau-amd)

See https://github.com/KhronosGroup/SPIRV-Tools/issues/5717 for more. Probably a trivial one-line fix, good low-hanging fruit for a newcomer?