llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
27.82k stars 11.46k forks source link

goo.gl is going away #99586

Closed pinskia closed 1 month ago

pinskia commented 1 month ago

See https://developers.googleblog.com/en/google-url-shortener-links-will-no-longer-be-available/

The 3 places in the sources where goo.gl is used and needs to be updated:

https://github.com/llvm/llvm-project/blame/0684db30a1e3226a0bfe4c5d839d1355a66ea4ba/llvm/docs/CompileCudaWithLLVM.rst#L517

https://github.com/llvm/llvm-project/blob/0684db30a1e3226a0bfe4c5d839d1355a66ea4ba/compiler-rt/lib/asan/asan_ignorelist.txt#L12

https://github.com/llvm/llvm-project/blob/0684db30a1e3226a0bfe4c5d839d1355a66ea4ba/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp#L14

thesamesam commented 1 month ago

compiler-rt/lib/asan/asan_ignorelist.txt:12:# Stack buffer overflow in VC/INCLUDE/xlocnum, see http://goo.gl/L4qqUG

This sends me to Bing...

/// (http://goo.gl/QKbem). We associate a few shadow bits with every

I'll fix this one as obvious now.

Endilll commented 1 month ago

@thesamesam the one that currently leads to bing is actually https://connect.microsoft.com/VisualStudio/feedback/details/829931/vs2012-and-vs2013-istream-code-reads-off-the-end-of-its-non-null-terminated-stack-copied-string, and thankfully it's on webarchive: https://web.archive.org/web/20140729123024/https://connect.microsoft.com/VisualStudio/feedback/details/829931/vs2012-and-vs2013-istream-code-reads-off-the-end-of-its-non-null-terminated-stack-copied-string

thesamesam commented 1 month ago

Ah, thanks! For some reason, I assumed the link had been changed via some Google setting by whoever made it so didn't think to check the redirect chain.

thesamesam commented 1 month ago

Done that one now too -- thank you!