search

llvm / llvm-zorg

Other
65 stars 94 forks source link

Fixed relative paths for Flang out-of-tree builder. #170

Closed vzakhari closed 5 months ago

vzakhari commented 5 months ago

After https://github.com/llvm/llvm-project/pull/87822 we can specify real relative paths from the flang build directory to the directories containing LLVM/CLANG/etc. projects' config files.

vzakhari commented 5 months ago

I do not know how to test this locally, so I am going to merge this and see what happens with the buildbots.

ceseo commented 5 months ago

OK, but it looks correct to me now.

@luporl probably knows how to test this locally.

luporl commented 5 months ago

@luporl probably knows how to test this locally.

It can be done, but it takes some work. Basically, you need to setup a local build master and add a build worker to it, that matches with the builder that you want to test. I don't know if there is an easier way to test it.

But let's hope this fixes the buildbot, which is broken anyway.

vzakhari commented 5 months ago

I forced the build, but it looks like the buildbot did not pick up these changes immediately. I will keep an eye on it.

luporl commented 5 months ago

The change will be picked up next time the build master is reconfigured, which can take some time.

vzakhari commented 5 months ago

Hi @omjavaid, sorry to bother you. By any chance do you know when https://lab.llvm.org/buildbot/#/builders/175 builder will pick up my changes from this PR?

luporl commented 5 months ago

Hi @omjavaid, sorry to bother you. By any chance do you know when https://lab.llvm.org/buildbot/#/builders/175 builder will pick up my changes from this PR?

https://lab.llvm.org/buildbot/#/builders/175 should pick your changes as soon as the build master is reconfigured. @gkistanova might know when that will happen.

vzakhari commented 5 months ago

Hi @luporl, can you please give me any pointers how to do setup a local build master and add a build worker to it, that matches with the builder that you want to test? I reverted my llvm-project changes, and I want to try my builder changes locally. It looks like this PR did not fix the issue, and the buildbot continued failing for a long time.

antmox commented 5 months ago

Hi @vzakhari , could this be the cause of current flang-aarch64-out-of-tree bot failure ? https://lab.llvm.org/buildbot/#/builders/175/builds/46750

luporl commented 5 months ago

It looks like we're out of luck, because it seems this patch was finally picked up by the build master, just when https://github.com/llvm/llvm-project/pull/87822 was reverted. @vzakhari, maybe if you reland https://github.com/llvm/llvm-project/pull/87822 now it will work.

luporl commented 5 months ago

Hi @luporl, can you please give me any pointers how to do setup a local build master and add a build worker to it, that matches with the builder that you want to test? I reverted my llvm-project changes, and I want to try my builder changes locally. It looks like this PR did not fix the issue, and the buildbot continued failing for a long time.

I've used some internal documents to setup a local build master and worker. I'm checking if it's possible to make it available. For setting a build worker, there is https://llvm.org/docs/HowToAddABuilder.html.

To create a master: https://docs.buildbot.net/current/tutorial/firstrun.html#creating-a-master

vzakhari commented 5 months ago

Thanks for the heads up! Yes, it looks like the change finally kicked in! I was told that the update happens every Friday, so it looks like it just did not happen the last Friday. I will reapply my llvm-project change.