search

llvm / torch-mlir

The Torch-MLIR project aims to provide first class support from the PyTorch ecosystem to the MLIR ecosystem.
Other
1.36k stars 507 forks source link

LTC enablement on various compile flows #1126

Open powderluv opened 2 years ago

powderluv commented 2 years ago

Tracking various modes to enable LTC in

henrytwo commented 2 years ago

Source builds (?)

Building LTC from source works, as far as the configs used in CI. Is there an instance where you see it failing still?

powderluv commented 2 years ago

Great to hear. Feel add / remove from the list. I thought it was disabled but maybe it wasn't

henrytwo commented 2 years ago

Here's a ticket to track the OOT build problem: https://github.com/llvm/torch-mlir/issues/1154

I believe the other build configs hit the same linkage issues as OOT, so it's possible that this may resolve the other problems you listed too.

henrytwo commented 2 years ago

@powderluv looks like OOT build is fixed now. I believe release build runs daily, so we'll find out if that works soon, but I'm not sure about running it on macOS. Is this something that can be triggered from CI?

powderluv commented 2 years ago

Sorry to report the nightly builds just failed: https://github.com/llvm/torch-mlir/runs/7735569399?check_suite_focus=true

I triggered a "oneshot" nightly that can build Release linux and macOS builds. You can also run it on main or any torch-mlir branch.

We probably should address the root cause or revert for now.

henrytwo commented 2 years ago

😭 I'll revert for now and investigate tomorrow

henrytwo commented 2 years ago

FYI I'm going to be working on fixing this problem in the following PR: https://github.com/llvm/torch-mlir/pull/1205