lm-sys / FastChat

An open platform for training, serving, and evaluating large language models. Release repo for Vicuna and Chatbot Arena.
Apache License 2.0
36.85k stars 4.54k forks source link

[important features] PDF uploader support #2165

Closed Dandelionym closed 1 year ago

Dandelionym commented 1 year ago

Hi, all. Thank you for sharing the code and the great contribution to the community.

Perhaps, the PDF reader could be provided as soon as possible for empowering the long context testing or usage. It would be great if we can use FastChat directly with various kinds of Vicuna models.

Thanks.

Best,

merrymercy commented 1 year ago

Contributions are welcome. Could you help us implement this in https://github.com/lm-sys/FastChat/blob/main/fastchat/serve/gradio_web_server.py ?

Devanshi-Crypto commented 1 year ago

Hey, could you possibly explain me this precisely what needs to be done? I want to contribute for the same.

Dandelionym commented 1 year ago

@Devanshi-Crypto Thank you for your reply. I wanted to ask if you have used Claude-2 before? It offers a feature to extract and analyze PDF files. First, there would be an upload button with a nice icon next to the input bar, allowing users to upload any PDF file from their device or a remote location. Second, the extracted text from the PDF would display in a pop-up panel. Finally, the text could be analyzed using prompts in a conversational style, like a ChatPDF with Claude. I think a PDF analysis feature would be very useful and amazing to have in FastChat, especially with the ability to use multiple models to analyze the same PDF. What do you think about adding something like this? I'm excited at the possibilities here!

Devanshi-Crypto commented 1 year ago

Hey! Omg this sounds really very cool. I've heard about Claude but haven't got my hands on it yet:(. But, okay so what do you think in what direction we can start working on this feature because this is really cool and I too am excited for this!!

merrymercy commented 1 year ago

@Devanshi-Crypto Basically, our goal is to implement something similar to Claude. You can try Claude and learn how it works https://claude.ai/chats.

To implement this, you can add a "upload a file" button to this demo server https://github.com/lm-sys/FastChat/blob/main/fastchat/serve/gradio_web_server.py. Then you can direct feed the file as a prefix of the prompt or build an embedding index over it. Feel free to try your own design.

Devanshi-Crypto commented 1 year ago

Hey, great I got the idea. I'd like to ask if there are any time constraints?

merrymercy commented 1 year ago

There are no time constraints.

Devanshi-Crypto commented 1 year ago

Okay, cool. Can you please assign this to me, I'll try my level best to implement it upto your expectations. Also for any kind of queries, where shall I contact you? On mail, slack or here itself?

Dandelionym commented 1 year ago

Let's go for the implementation!

Here is the Slack invitation: MIAIR

Welcome to join!

angelinashepherd commented 10 months ago

Is this no longer an available feature? Not seeing a way to upload a file (on mobile) from https://arena.lmsys.org

surak commented 10 months ago

Is this no longer an available feature? Not seeing a way to upload a file (on mobile) from https://arena.lmsys.org

Hello @angelinashepherd, the whole discussion is about development of such a feature, which clearly wasn't implemented yet. I don't understand the "no longer available", as it was not yet implemented.

Everyone is welcome to contribute, and there's even this slack server linked in the comment before yours, but it's clearly not there yet.

angelinashepherd commented 10 months ago

@surak the issue was last marked as "closed as completed", which gave the impression that it was implemented at some point. Furthermore, Slack link is not working.

surak commented 10 months ago

Ah, sorry I missed that. But I see no merge request here, so it makes sense to keep it open