Open jthomaskerr opened 10 years ago
Thank you for the debug. The assumption was that p4 diff2 (due to -G) always returns some object and there is a test for equal tree. This seems to be working for stream "copy" at least -- but perhaps this is not always the case. What p4 client/server versions are you using?
Unfortunately p4 command line documentation is not comprehensive, therefore it's not clear whether this is a valid result. Is there anything special about the failing case beside that the trees are identical?
If diff2 result is indeed empty a complete fix should probably also include a check for p4 command return code (currently it is ignored due to the ignore_error flag passed to p4CmdList). Pull request is welcome.
P4 client: Rev. P4/MACOSX105X86_64/2013.3/740675 (2013/11/11). Server version: P4D/NTX64/2013.1/659207 (2013/06/18)
I'll organise the fix and get back to you.
Hi,
I am trying to initialise a repo with a number of streams from our p4 depot.
The process gets to about 20% and then it dies with the following error:
In debugging I find that the p4 command raises an EOFError without adding any results (not surprising given the -q flag). When running the p4 command manually I see that every result entry gives "identical".
Consequently, I have worked around the issue (I hope) by adding a condition that returns true if diff is empty:
Is this correct?