Open MarlonWelter opened 5 years ago
The sample matches check should be easy to implement with our new api.
The /api/trophies?platformId=euw1&matchId=123&summonerName=abc
endpoint returns the obtained trophies for a match and summoner.
https://github.com/lmachens/trophy-hunter/blob/master/src/api/endpoints/trophies/index.ts
We could add a new endpoint which tries out multiple matches to test the difficulty and stability of a trophy. /api/test-trophy?trophyName=trophyHunter
for example.
The achievment stats for recent matches could be part of the trophy stats collection. not sure if we really need it - what is the reason? We can think about a dynamic difficulty. Instead of hardcoding the score/difficulty, we can update it after every match.
I think the current way to calculate the achievement rate for our trophies is not very good, because it doesn't take into consideration that the difficulty of trophies can change vastly over a long time. I think we should replace it with a new method that is more weighted towards recent matches. Or at least, we should add another field "recent achievement rate".
the dynamic difficulty I don't like that much, because some trophies are not really hard to get but will still have a low achievement rate (e.g. "place 6 control wards"). I think it is good to not completely automate this.
With the changes of season 9, some trophies might have a huge change in difficulty (specially rune related). It's time to check for that.
In the long run it would be nice to have two more options implemented for our trophies: