lmakarov / dde

[DEPRECATED] Docker and Docker Compose based environment for Drupal
MIT License
128 stars 37 forks source link

Winpty is missed on Windows #135

Closed xxalhixx closed 8 years ago

xxalhixx commented 8 years ago

`

if is_windows; then

Workaround - run docker exec via winpty (console.exe) to get a tty console in cygwin.

  if is_binary_found 'console'; then
      winpty_cmd='console'
  else
      echo-red 'Winpty (console.exe) binary missing.'
      echo 'Run "dsh install prerequisites" to install it.'
      exit 1
  fi

fi In this code script looks for console.exe. Since [winpty 0.3.0](https://github.com/rprichard/winpty/releases/tag/0.3.0) console.exe was renamed to winpty.exe Is replacing echo message bywinpty_cmd='winpty'` will fix this issue?

achekulaev commented 8 years ago

@xxalhixx thank you for report. I have fixed it in version (1.20.1). It's not in master yet.

If you need it right now you can update to dev version by running

DRUDE_BRANCH=develop dsh update dsh
achekulaev commented 8 years ago

@lmakarov I guess candidate for hotfix release