search

lmammino / godaddy-dns

A Node.js script to programmatically update GoDaddy DNS records
https://lmammino.github.io/godaddy-dns/
MIT License
78 stars 21 forks source link

fix mutation of recordDefaults #18

Closed anotherZero closed 7 years ago

anotherZero commented 7 years ago

fixing a derp move. use blank object for Object.assign target to prevent unintended mutation

anotherZero commented 7 years ago

May also want to tag this for package manager "patch" release.

lmammino commented 7 years ago

Another good catch (I missed it during review 😰 ).

I will take care of version bumping, tagging and releasing after this is merged.

(I also have a plan - #16 - to automate all of this through CI as I have done in most of my newer node libs)