search

lmammino / godaddy-dns

A Node.js script to programmatically update GoDaddy DNS records
https://lmammino.github.io/godaddy-dns/
MIT License
78 stars 21 forks source link

TypeError while launching it #23

Closed russellhoff closed 6 years ago

russellhoff commented 6 years ago

Hi! I'm sorry to bother you again. I just installed the latest version and created a config file like the following:

{
  "apiKey": "****",
  "secret": "****",
  "domain": "mydomain.com",
  "records": [
    {"type": "A", "name": "@", "ttl": 600}
  ]
}

Afterwards, I type godaddy-dns -c mydomain.com-config.json and an exception is thrown:

[Wed Nov 29 2017 19:30:57 GMT+0100 (CET)] TypeError: Promise.resolve(...).each is not a function

PS: My godaddy keys are production's.

Thank you again!

russellhoff commented 6 years ago

@lmammino have you had the chance to review this issue? I can help. Thank you!

lmammino commented 6 years ago

Hey @russellhoff, i had a quick look and I think there's actually a bug introduced in one of the latest release. I am going to take care of fixing this asap and introduce a unit test suite to avoid this will happen again in the future?

russellhoff commented 6 years ago

Okay, thank you!

lmammino commented 6 years ago

@russellhoff, version 1.2.0 just landed. It should fix the issue!

Let me know if it works for you

russellhoff commented 6 years ago

I'll try it later and keep you informed ;)

russellhoff commented 6 years ago

It's working, thank you!

lmammino commented 6 years ago

Glad to hear! I Look forward to getting your feedback. Also feel more than welcome to keep contributing the project

russellhoff commented 6 years ago

Sure! The tool works as expected and no enhancements come to my mind :)