search

lmammino / godaddy-dns

A Node.js script to programmatically update GoDaddy DNS records
https://lmammino.github.io/godaddy-dns/
MIT License
78 stars 21 forks source link

Issue 31 update record array #32

Closed aandrulis closed 6 years ago

aandrulis commented 6 years ago

I could not find any godaddy doc update to their api to confirm they broken the api. It's my first npm work, so I've just created an array, add the old request body and updated the tests. Please review if that is a proper solution for the issue.

lmammino commented 6 years ago

Thanks for your PR, I copied some parts of it in the last release. Didn't merge this one because I felt there was a lot more than needed (e.g. many changes in the package.json)

aandrulis commented 6 years ago

Thanks. Sorry the extra work, I’ll be more careful in future, i was sure i’ve removed the packages changes. :( They’re there just because I have freshly installed npm and the dependencies so i could run the tests. Have a nice weekend.

On Sun, 22 Apr 2018 at 09:50, Luciano Mammino notifications@github.com wrote:

Thanks for your PR, I copied some parts of it in the last release. Didn't merge this one because I felt there was a lot more than needed (e.g. many changes in the package.json)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lmammino/godaddy-dns/pull/32#issuecomment-383365770, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjUumpr9D_4MS5WadmKRiZ6s-Wl3_N-ks5trERCgaJpZM4Telvq .

lmammino commented 6 years ago

No worries at all, I really appreciated the contribution anyway and added an official mention in the README. Just thought it would have been faster to reapply changes from this PR and #30 rather than asking both to do separate changes and then wait for things to be synchronised.

Thanks again for your contribution to this little open source project! 😉