lmammino / tall

Promise-based, No-dependency URL unshortner (expander) module for Node.js
https://lmammino.github.io/tall/
MIT License
72 stars 7 forks source link

bitly ebay short link don't work #19

Closed vrenda16 closed 3 years ago

vrenda16 commented 4 years ago

Hi,

I have a issue when i try to unshort a bitly ebay link (https://ebay.to/xxxxx). The method return www.ebay.com url only. Someone have the same issue?

lmammino commented 4 years ago

Hello @vrenda16, do you have an actual valid link that i can play with to try to debug this issue? thanks :)

mifi commented 3 years ago

I have a similar issue:

require('tall').tall('http://bit.ly/fkWS88').then(console.log)
https://news.ycombinator.com/item

Should be http://news.ycombinator.com/item?id=2025354 (query string missing from tall):

curl -v http://bit.ly/fkWS88
*   Trying 67.199.248.11...
* TCP_NODELAY set
* Connected to bit.ly (67.199.248.11) port 80 (#0)
> GET /fkWS88 HTTP/1.1
> Host: bit.ly
> User-Agent: curl/7.64.1
> Accept: */*
> 
< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Fri, 02 Apr 2021 15:18:37 GMT
< Content-Type: text/html; charset=utf-8
< Content-Length: 130
< Cache-Control: private, max-age=90
< Location: http://news.ycombinator.com/item?id=2025354
< Set-Cookie: _bit=l32fiB-81903003860e6a0962-00F; Domain=bit.ly; Expires=Wed, 29 Sep 2021 15:18:37 GMT
< Via: 1.1 google
< 
<html>
<head><title>Bitly</title></head>
<body><a href="http://news.ycombinator.com/item?id=2025354">moved here</a></body>
* Connection #0 to host bit.ly left intact
</html>

I think the key to the issue is the http instead of https

lmammino commented 3 years ago

Hello @mifi, thanks for reporting this. Which version of tall are you using?

mifi commented 3 years ago

Hi! Tested with 4.0.0, same issue

mifi commented 3 years ago

awesome!

lmammino commented 3 years ago

This should be fixed in 4.0.1 (just released) :)