lmammino / tall

Promise-based, No-dependency URL unshortner (expander) module for Node.js

https://lmammino.github.io/tall/

MIT License

72 stars 7 forks source link

Disable ESLint rule conflicting with Prettier #55

Closed karlhorky closed 2 years ago

karlhorky commented 2 years ago

Prettier does not have a way to configure a space before the parenthesis - they recommend disabling this rule

Apart from this rule, it seems all the rest of the preferences can be configured in Prettier (see #53)

karlhorky commented 2 years ago

Rebasing this on top of #56, so that we can avoid the duplication

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4a6499b). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #55   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        35           
  Branches        ?         5           
========================================
  Hits            ?        35           
  Misses          ?         0           
  Partials        ?         0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

karlhorky commented 2 years ago

This should be good to go now @lmammino 🙌 I documented my progress up in my original comment above: https://github.com/lmammino/tall/pull/55#discussion_r973349191

lmammino commented 2 years ago

Thanks for the hard work on this @karlhorky

karlhorky commented 2 years ago

Glad to help, thanks for the merge! Now finally back to #43