lmammino / tall

Promise-based, No-dependency URL unshortner (expander) module for Node.js

https://lmammino.github.io/tall/

MIT License

72 stars 7 forks source link

Upgrade to npm@^9.0.0, drop Node.js 17 in favor of 19 #57

Closed karlhorky closed 2 years ago

karlhorky commented 2 years ago

Hey @lmammino 👋 Hope you are well.

Since npm 9.0.0 was released, I thought it would make sense to upgrade to the newer version.

And because Node.js 17 is no longer supported, I dropped this in favor of Node.js 19.

lmammino commented 2 years ago

Hey @karlhorky, thanks for submitting this but it seems to be breaking our CI run...

karlhorky commented 2 years ago

Yep, just moved from 17 to 19 to fix that... all green! ✅

codecov[bot] commented 2 years ago

Codecov Report

Merging #57 (02faec9) into main (dc0d86e) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           52        52           
  Branches         9         9           
=========================================
  Hits            52        52

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

karlhorky commented 2 years ago

Thanks for the review + merge!

lmammino commented 2 years ago

Thanks for the PR, i'll release a new major shortly!