lmangall / Raycaster-Game-Engine

3 stars 1 forks source link

readme : document the Makefile #152

Open lmangall opened 8 months ago

lmangall commented 8 months ago

@552020 your Makefile is pretty fancy, and useful, and I think that's one of the "knowledge acquired" points that should be in the Readme

552020 commented 8 months ago

Feel free to feature it!

What should be in our README in my opinion, should the problem how to use actually MLX, i.e. the problem we had with walls and background. I guess at the beginning we were thinking that we need to push the image (I'm not sure if push is the correct term) to the window everytime we change the image, but as far I understand the library has a sort of event listener that update it automatically. It's the conversation you linked yesterday. I'm also not sure if this behavior is documented in the docs of the mlx library. Eventually we can suggest a modification of the docs: so you would have maybe also your first commit accepted in a open source project!

lmangall commented 8 months ago

so you would have maybe also your first commit accepted in a open source project!

It sounds like not being a virgin anymore

Do you have your first ?

The doc for MLX is quite light (maybe intentionnaly) but it is true that this seems to be an essential information

552020 commented 8 months ago

It sounds like not being a virgin anymore

Yes, I add a PR in MLX42 already accepted! I spot a typo it's instead of its! 😀

The doc for MLX is quite light (maybe intentionnaly) but it is true that this seems to be an essential information

Just for me to be clear about it, we are talking about the fact that in MLX42 when you modify an image that you already put to the window the library already update the image in the window without the need of reputting it on the window, and this is the reason why the minimap (as a black background) was behind the walls. It would be anyway another issue than the one discussed in this issue.

lmangall commented 8 months ago

Yes I was talking about that