lmarzen / esp32-weather-epd

A low-power E-Paper weather display powered by an ESP32 microcontroller. Utilizes the OpenWeatherMap API.
GNU General Public License v3.0
2.33k stars 179 forks source link

Always do SPI remapping #101

Open blind-oracle opened 1 month ago

blind-oracle commented 1 month ago

First, thanks for the awesome project!

I had a small problem when configuring the firmware - when the board is set to the recommended Despi C02 then the SPI bus is not remapped to the pins that are specified in the config.cpp. When using different ESP32 boards (I've used ESP32-S3) it causes frustration since you can't get the display working.

I'd recommend to just move this block out of #ifdef so that it executes for all board types (shouldn't hurt I guess)

  SPI.end();
  SPI.begin(PIN_EPD_SCK,
            PIN_EPD_MISO,
            PIN_EPD_MOSI,
            PIN_EPD_CS);
lmarzen commented 1 month ago

`Thanks for troubleshooting this and presenting a solution. I am in the middle of moving, but I will apply this fix in the coming weeks.