search

lmarzen / esp32-weather-epd

A low-power E-Paper weather display powered by an ESP32 microcontroller. Utilizes the OpenWeatherMap API.
GNU General Public License v3.0
2.49k stars 196 forks source link

Make it possible to show rain volume #64

Closed cwitting closed 10 months ago

cwitting commented 10 months ago

This simply makes it possible to switch between showing Posibility of Precipitation (PoP) and rain volume in mm on the graph

lmarzen commented 10 months ago

I like this addition. I have a few suggestions. Some people may wish to change the unit. Particularly, I would advocate for an option to have the choice between mm, inches, and cm. Second thing to note is that OpenWeatherMap has separate fields for rainfall and snowfall. I think we should add these fields so they are representative of the precipitation regardless of the season someone may be experiencing,

Let me know what you think?

cwitting commented 10 months ago

Yes, I agree. I have added another commit which makes it possible to specify the unit, as well as combining snow and rain precipitation.

lmarzen commented 10 months ago

Looks good, I'll test it out this weekend and merge it.

lmarzen commented 10 months ago

I have been busy with school work. I will try to get this merged over the thanksgiving holiday.

lmarzen commented 10 months ago

Overall this is a great contribution. Thank you. I added automatic precision adjustments for the y-axis ticks to reduce the likelihood that the rainfall will run off the screen.