search

lmarzen / esp32-weather-epd

A low-power E-Paper weather display powered by an ESP32 microcontroller. Utilizes the OpenWeatherMap API.
GNU General Public License v3.0
2.33k stars 179 forks source link

Add daily precipitation feature. #84

Closed asandhu3 closed 2 months ago

asandhu3 commented 4 months ago

I think this adds a valuable piece of data to the forecast section. I've been using this for a while and thought I'd make some proper flags and logic for different units and throw it into a PR if you think it's useful to add. I attempted to add a 16x16 icon beside the number to indicate what it is but it looked a bit cluttered and the very small icons don't render too well IMO.

This is my first exposure to C++ so possibly some issues but feel free to review and offer suggestions!

lmarzen commented 3 months ago

Sorry for the delay, I have not gotten a chance to review this as I have been busy. Just leaving this message to let you know that I have not forgotten about this. I think this is a nice feature and will hopefully find time to check it out in the coming week.

asandhu3 commented 2 months ago

@lmarzen I rebased to resolve the conflict but Github auto-closed the PR when I pushed. Let me know if you're able to re-open it otherwise I can create a new PR.

lmarzen commented 2 months ago

It's letting me reopen it.

lmarzen commented 2 months ago

Never mind. It's saying it was force pushed. This UI is being finicky. please create a new PR.