updated 3D noise array function

[Julian-Wyatt]

given array coordinate inputs x,y,z, the function returns 3D array of shape (z,y,x) instead of 1D array.

[lmas]

Hi thank you for this. Would you be willing to update it further and match it with #25? I'm asking you because your PR was smaller of the two.

In short:

• Add docstring and type hints to to the public func noise3array (not _noise3array)
• Add back the old input variable names and use x_i for the loop vars
• Initialize the noise array with np.empty and avoid using "(y * Y.size + x)"

[Julian-Wyatt]

Hope those two commits fix the issues and help. I've used the other PR for consistency.

[lmas]

Whoa hold up now mister. I appreciate your time and effort, thanks, but now you've started to add in partial code that's unrelated to your initial PR.

It's not my intention to sound like an ungrateful muppet, I just want to help you get it right while keeping things clean for everyone else :)

It's way easier to work with small and clean PRs that contains just a single feature/update/whatever. So your initial PR was good. But it would had been better to open up a new PR for that third commit instead.

---

Edit: I also now realise that neither the linter nor the autoformatter will catch misaligned docstrings. This issue is on me though.

[lmas]

Can you revert the commit with the new fractal noise func and add it as a separate PR? And please run the new formatter on your code.

[Julian-Wyatt]

I've removed the ident from the doc string. I've reverted the final commit, adding the potential new feature. Instead added this as another PR, building on from this branch.

[lmas]

Thank you, looking better now! I don't have time during the week so I'll try to verify and merge this weekend 👍