Repository permits pushing to development branch without testing first.

lmaurits / BEASTling

A linguistics-focussed command line tool for generating BEAST XML files.

BSD 2-Clause "Simplified" License

20 stars 6 forks source link

Repository permits pushing to development branch without testing first. #169

Closed Anaphory closed 7 years ago

Anaphory commented 7 years ago

I just pushed to this repository when actually I wanted to push to my own fork.

It went through without complaints.

Please protect pushing to develop in the same fashion as merging pull requests are tested and as (hopefully) pushing to the master branch is prohibited.

Anaphory commented 7 years ago

For reference: #165 was the pull-request that got merged without sufficient test coverage.

lmaurits commented 7 years ago

Alright, I think I've done this now? Enabled "Require status checks to pass before merging" for both master and develop.

lmaurits commented 7 years ago

Do you want to try to reverse that merge, or just fix whatever problems there are with it in develop? Do you need me to do anything to facilitate fixing this?

Anaphory commented 7 years ago

There are three things to that merge:

Merging master into develop, because they had separated surprisingly far;
Initial CLDF support;
Being more verbose about ASR.

All tests had succeeded, the CLDF support needs improvement and test coverage. Given that, I myself would be happy to fix these things inside develop.

lmaurits commented 7 years ago

Okay, great! Time to close this?