lmaurits / BEASTling

A linguistics-focussed command line tool for generating BEAST XML files.
BSD 2-Clause "Simplified" License
20 stars 6 forks source link

Release 1.4 #201

Closed Anaphory closed 6 years ago

Anaphory commented 6 years ago

Changes on the development branch for version number 1.4.0, including the increase in version number, which is not part of develop.

codecov-io commented 6 years ago

Codecov Report

Merging #201 into master will decrease coverage by 0.91%. The diff coverage is 92.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   94.25%   93.33%   -0.92%     
==========================================
  Files          19       21       +2     
  Lines        1948     2564     +616     
==========================================
+ Hits         1836     2393     +557     
- Misses        112      171      +59
Impacted Files Coverage Δ
beastling/clocks/baseclock.py 100% <ø> (+6.06%) :arrow_up:
beastling/clocks/relaxed.py 100% <100%> (ø) :arrow_up:
beastling/models/geo.py 96.05% <100%> (+0.4%) :arrow_up:
beastling/models/bsvs.py 96.42% <100%> (+0.06%) :arrow_up:
beastling/__init__.py 100% <100%> (ø) :arrow_up:
beastling/beast_maps.py 100% <100%> (ø) :arrow_up:
beastling/report.py 94.5% <100%> (+0.06%) :arrow_up:
beastling/models/mk.py 100% <100%> (ø) :arrow_up:
beastling/models/binary.py 84.84% <62.5%> (-1.43%) :arrow_down:
beastling/models/covarion.py 86.45% <85%> (-5.96%) :arrow_down:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update affdd4e...e821ea8. Read the comment docs.

Anaphory commented 6 years ago

@lmaurits I'd be tempted to merge this as-is and deal with the missing coverage as part of general attempts to improve structure.

Anaphory commented 6 years ago

Testing model selection at least through a beastrun test would be nice at some point. I still haven't managed to compile model-selection on my system, otherwise I might have tried committing such a test still for 1.4

lmaurits commented 6 years ago

Fully agree with both of the above! I released "as is" just to get it out before I went AFK for a long time during my Baltic journey (probably this happens tomorrow). For 1.5, I am happy to make passing Codecov a requirement for merging into master, so that we are constantly getting better.

Thanks a lot for your hard work during your visit to get 1.4.0 out!