search

lmaurits / BEASTling

A linguistics-focussed command line tool for generating BEAST XML files.
BSD 2-Clause "Simplified" License
20 stars 6 forks source link

Fix some more issues with IDs #234

Closed Anaphory closed 5 years ago

Anaphory commented 5 years ago

Hopefully without introducing too much other stuff

codecov-io commented 5 years ago

Codecov Report

Merging #234 into develop will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
- Coverage    93.67%   93.66%   -0.01%     
===========================================
  Files           25       25              
  Lines         2925     2922       -3     
===========================================
- Hits          2740     2737       -3     
  Misses         185      185
Impacted Files Coverage Δ
beastling/models/binaryctmc.py 90.9% <100%> (ø) :arrow_up:
beastling/models/covarion.py 95.77% <100%> (ø) :arrow_up:
beastling/models/basemodel.py 93.57% <100%> (-0.29%) :arrow_down:
beastling/models/binary.py 89.85% <100%> (-1.5%) :arrow_down:
beastling/distributions.py 97.59% <0%> (+4.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b7e03e...bbc0ee1. Read the comment docs.

lmaurits commented 5 years ago

Sorry, but can you remove the commit for fixing the ID problems from this? It'll conflict with corresponding changes I've already made in my working copy and am about to commit. The binary stuff, anyway. What's with that data ID change in BaseModel? I didn't think I had changed anything in BaseModel...

Anaphory commented 5 years ago

I'll just discard this, and if anything similar pops up after the refactorization, we can handle it then, using our new and better infrastructure.