lmaurits / BEASTling

A linguistics-focussed command line tool for generating BEAST XML files.
BSD 2-Clause "Simplified" License
20 stars 6 forks source link

Should base-clocks/models/priors be abstract? #255

Open Anaphory opened 4 years ago

Anaphory commented 4 years ago

BaseClock doesn't have a branch rate model, which to me makes that method pretty abstract, so the whole class is? It also lacks __type__ and __distribution__, and declaring it abstract would prevent an accidental instantiation if after some refactoring [clock] type=base would theoretically run etc.

Originally posted by @Anaphory in https://github.com/lmaurits/BEASTling/pull/248