search

lmaurits / phyltr

Unix filters for manipulating and analysing (samples of) phylogenetic trees represented in the Newick format
GNU General Public License v3.0
3 stars 4 forks source link

Remove omnipresent files argument #28

Closed xrotwang closed 5 years ago

xrotwang commented 5 years ago

We can even shave off another @classmethod - statement count down to 1040.

closes #25

codecov-io commented 5 years ago

Codecov Report

Merging #28 into develop will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #28      +/-   ##
==========================================
- Coverage    99.81%   99.8%   -0.01%     
==========================================
  Files           31      31              
  Lines         1058    1038      -20     
==========================================
- Hits          1056    1036      -20     
  Misses           2       2
Impacted Files Coverage Δ
src/phyltr/commands/clades.py 100% <ø> (ø) :arrow_up:
src/phyltr/commands/cat.py 100% <ø> (ø) :arrow_up:
src/phyltr/commands/prune.py 100% <100%> (ø) :arrow_up:
src/phyltr/commands/grep.py 100% <100%> (ø) :arrow_up:
src/phyltr/__main__.py 100% <100%> (ø) :arrow_up:
src/phyltr/commands/base.py 100% <100%> (ø) :arrow_up:
src/phyltr/utils/phyltroptparse.py 100% <100%> (ø) :arrow_up:
src/phyltr/commands/subtree.py 100% <100%> (ø) :arrow_up:
src/phyltr/commands/sibling.py 100% <100%> (ø) :arrow_up:
src/phyltr/utils/misc.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b7eea4...13a78a4. Read the comment docs.

xrotwang commented 5 years ago

@lmaurits what are your thoughts on pep8, btw? I actually found using flake8 - and sticking to its recommendations - quite liberating; I basically stopped thinking and having an opinion on code style issues, and simply do what the tool tells me.

lmaurits commented 5 years ago

@lmaurits I actually found using flake8 - and sticking to its recommendations - quite liberating; I basically stopped thinking and having an opinion on code style issues, and simply do what the tool tells me.

War is peace! Freedom is slavery! Ignorance is strength! 😛

Well, I understand what you mean. After a sufficient number of beers I will bitterly complain that standardising on spaces for indentation instead of tabs was a mistake, but realistically I don't think I have any serious objections to anything in PEP8 and I'm sure 90% of my violations of it can be attributed to laziness or ignorance.

Were you proposing integrating flake8 into tox or Travis or something to enforce compliance?

xrotwang commented 5 years ago

I wouldn't want to force it via Travis, I think. But I typically have a line saying run "flake8 src/" in my projects' RELEASING.md. So it's a stated goal to be pep8 compliant. Rather than forcing it, I'd be waiting for black to be available on python 3.5 (or upgrading my python to 3.6), and then just have black reformat everything upon each commit.

lmaurits commented 5 years ago

That sounds entirely reasonable to me.