lmcgartland / graphene-file-upload

Enhances Graphene Django GraphQL Server for intuitive file uploads via GraphQL mutations.
MIT License
287 stars 50 forks source link

Exclude 'tests' from the package list #43

Closed fhennig closed 3 years ago

fhennig commented 4 years ago

As noted in #41, the 'tests' directory is falsely added to the list of packages. This pull request excludes the tests directory from that list.

fhennig commented 4 years ago

The error from the CI:

$ tox

GLOB sdist-make: /home/travis/build/lmcgartland/graphene-file-upload/setup.py

py35 create: /home/travis/build/lmcgartland/graphene-file-upload/.tox/py35

py35 installdeps: .[all], coverage, pytest, pytest-cov, pylint

py35 inst: /home/travis/build/lmcgartland/graphene-file-upload/.tox/.tmp/package/1/graphene_file_upload-1.2.2.zip

py35 installed: aniso8601==7.0.0,astroid==2.4.2,attrs==20.2.0,click==7.1.2,coverage==5.3,Django==2.2.16,Flask==1.1.2,Flask-GraphQL==2.0.1,graphene==2.1.8,graphene-django==2.13.0,graphene-file-upload==1.2.2,graphql-core==2.3.2,graphql-relay==2.0.1,graphql-server-core==1.2.0,importlib-metadata==2.0.0,iniconfig==1.0.1,isort==4.3.21,itsdangerous==1.1.0,Jinja2==2.11.2,lazy-object-proxy==1.4.3,MarkupSafe==1.1.1,mccabe==0.6.1,packaging==20.4,pathlib2==2.3.5,pluggy==0.13.1,promise==2.3,py==1.9.0,pylint==2.6.0,pyparsing==2.4.7,pytest==6.1.0,pytest-cov==2.10.1,pytz==2020.1,Rx==1.6.1,singledispatch==3.4.0.3,six==1.15.0,sqlparse==0.3.1,toml==0.10.1,typed-ast==1.4.1,Unidecode==1.1.1,Werkzeug==1.0.1,wrapt==1.12.1,zipp==1.2.0

py35 run-test-pre: PYTHONHASHSEED='338683047'

py35 run-test: commands[0] | -coverage clean

Unknown command: 'clean'

Use 'coverage help' for help.

Full documentation is at https://coverage.readthedocs.io

py35 run-test: commands[1] | pylint graphene_file_upload

************* Module graphene_file_upload.utils

graphene_file_upload/utils.py:61:0: R1721: Unnecessary use of a comprehension (unnecessary-comprehension)

************* Module graphene_file_upload.django

graphene_file_upload/django/__init__.py:22:15: R1725: Consider using Python 3 style super() without arguments (super-with-arguments)

************* Module graphene_file_upload.flask

graphene_file_upload/flask/__init__.py:23:15: R1725: Consider using Python 3 style super() without arguments (super-with-arguments)

-----------------------------------

Your code has been rated at 9.52/10

ERROR: InvocationError for command /home/travis/build/lmcgartland/graphene-file-upload/.tox/py35/bin/pylint graphene_file_upload (exited with code 8)

___________________________________ summary ____________________________________

ERROR:   py35: commands failed

The command "tox" exited with 1.

Done. Your build exited with 1.

The reported error is only a style issue (super-with-arguments). The code needs to stay like this to remain backwards compatible with python 2.