search

lmcinnes / pynndescent

A Python nearest neighbor descent for approximate nearest neighbors
BSD 2-Clause "Simplified" License
899 stars 105 forks source link

Only one update method #189

Closed Petkomat closed 2 years ago

Petkomat commented 2 years ago

Merged the two index-updating methods into one and improved it (now, it should work also in all cases (update all/no data ...)

lmcinnes commented 2 years ago

Just a minor thing, but preserving the API would be nice (I guess there are some flow-on changes that may be required; docstrings, and possibly tests), but hopefully that's all minor. Other than that LGTM.

Petkomat commented 2 years ago

Yeah, these were all only minor changes. For the sake of completeness, I updated the tests also, even though that wouldn't be necessary (because we explicitly called update(xs_updated=..., xs_fresh=...)).