search

lmcinnes / pynndescent

A Python nearest neighbor descent for approximate nearest neighbors
BSD 2-Clause "Simplified" License
899 stars 105 forks source link

Newest version breaks with UMAP #217

Open guyronhuji opened 1 year ago

guyronhuji commented 1 year ago

Installing the new version and running UMAP, first attempt runs ok, all subsequent ones crash (likely due to some memory leak). Downgrading to the previous version solves the problem.

lmcinnes commented 1 year ago

That seems not good ... I'll try to check this when I get some time.

jakobhansen-blai commented 1 year ago

I just ran into the same issue. It appears to be due to numba caching in rp_trees.py. Removing cache=True from make_dense_tree()/make_sparse_tree() seems to fix it.

lmcinnes commented 1 year ago

Thanks @jakobhansen-blai I'll try to get a new release out tomorrow to fix this.