search

lmcinnes / umap

Uniform Manifold Approximation and Projection
BSD 3-Clause "New" or "Revised" License
7.39k stars 803 forks source link

Numba.jit and numpy dependency problems #1048

Closed ekwan closed 1 year ago

ekwan commented 1 year ago

Hi, I'm getting this warning with umap 0.5.3:

  @numba.jit()
/Users/kwaneu/sw/miniconda/miniconda3/envs/python/lib/python3.11/site-packages/umap/umap_.py:660: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.

I'm also seeing umap complain it only supports up to numpy 1.24.0.

mbelak-dtml commented 1 year ago

This is already fixed on main by https://github.com/lmcinnes/umap/commit/8a9418266d9e7825bfe974cf2d52fbafca32e1f1. However, this is not released yet.

@lmcinnes Any plans for releasing?

lmcinnes commented 1 year ago

There should be a new release out now, and hopefully this is now resolved.

mbelak-dtml commented 1 year ago

@ekwan The issue is resolved in the latest release. Can we close this?

ekwan commented 1 year ago

Checked and this has fixed the problem! Thank you!