search

lmcinnes / umap

Uniform Manifold Approximation and Projection
BSD 3-Clause "New" or "Revised" License
7.46k stars 809 forks source link

Fix numba call for deprecation of nopython=True #1061

Closed aarmey closed 2 weeks ago

aarmey commented 1 year ago

Fixes #1048 for umap.plot.

I think this line was missed during the changes in v0.5.4.

lmcinnes commented 1 year ago

This is actually a nopython=False case; I think in practice it probably needs to be updated to use the python object context handling that has been added to numba. I'll try to get around to that in due course.

pep8speaks commented 1 year ago

Hello @aarmey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 209:89: E501 line too long (92 > 88 characters)

aarmey commented 1 year ago

@lmcinnes you might want to avoid the additional complexity, but here is a version that can be fully compiled by Numba.