search

lmcintyre / OrchestrionPlugin

Simple BGM management plugin for XivLauncher
MIT License
20 stars 25 forks source link

Game crashes if player tries to play a song from an expansion that they do not own #11

Closed ryankhart closed 2 years ago

ryankhart commented 2 years ago

I just had a crash because I was browsing all the "Answers" songs in Orchestrion Plugin, and one of them was a piano version that ended up being from Endwalker. I only own Shadowbringers so far. When I double clicked it, I got a dialog box telling me something, and when I dismissed it, the game crashed.

It's easy to work around the issue by not clicking on anything that says an expansion name that I don't have or by just purchasing the latest expansion, but here's this issue anyway. If I'm feeling motivated enough, I might try to fix it and submit a pull request.

ryankhart commented 2 years ago

image

lmcintyre commented 2 years ago

Thanks for the bug report. I'll get this done for the next release. I think I'll make it so that these listings will appear, but be unplayable and include in the tooltip that it's unplayable due to expansions not owned.

ryankhart commented 2 years ago

Sweet! I'll be looking forward to learning how you do it. I tried forking the repo and fixing it myself, but I got stuck.

lmcintyre commented 2 years ago

This was fixed in 12524afdafdacee9be10ffa7688e9d941491118f / 1.8.3.0. Thank you!