lmcintyre / OrchestrionPlugin

Simple BGM management plugin for XivLauncher
MIT License
20 stars 25 forks source link

prevent crash on bgms[sheet.id] fails #25

Closed hibiyasleep closed 1 year ago

hibiyasleep commented 1 year ago

if xiv_bgm.csv contains a line with song ID that does not exist in BGM sheet, plogon will be crash; this PR does dirty null-check on it.

ps: can red hightlighting on nonexistent song (removed on 84a22d9c) be added again? this made direct indication that 'hey you have illegal csv entry' or somewhat.

lmcintyre commented 1 year ago

Thanks for this. I added back the red color in 9fde0358964fc03e9794be2bdfee2e958c7c0a46.