lmcintyre / OrchestrionPlugin

Simple BGM management plugin for XivLauncher
MIT License
20 stars 25 forks source link

Allow changing which chat channels the plugin sends "now playing" messages in #35

Closed anamayagarodia closed 9 months ago

anamayagarodia commented 1 year ago

I like the feature where the plugin sends "now playing" however, it currently sends it to every chat channel - general, battle, event and a custom FC one I have. I would like it to only send to the general channel.

anamayagarodia commented 1 year ago

I haven't really looked into developing dalamud plugins too much yet, and I'm not sure why this particular chat type is used but I believe changing DalamudApi.PluginInterface.GeneralChatType, line 123 in Orchestrion/OrchestrionPlugin.cs to Dalamud.Game.Text.XivChatType.SystemMessage, might help make it filterable by the default XIV client chat log settings. However, I am not sure if PluginInterface.GeneralChatType is being used for a specific purpose and if using SystemMessage might break that.

Thanks! :D

lmcintyre commented 1 year ago

You can change the chat channel that messages go into by changing the Dalamud chat channel setting in /xlsettings.

I am probably going to separate this out eventually so they can be distinct settings.

On Sun, Jun 25, 2023, 11:15 AM Anamaya Garodia @.***> wrote:

I haven't really looked into developing dalamud plugins too much yet, and I'm not sure why this particular chat type is used but I believe changing DalamudApi.PluginInterface.GeneralChatType, line 123 in Orchestrion/OrchestrionPlugin.cs to Dalamud.Game.Text.XivChatType.SystemMessage, might help make it filterable by the default XIV client chat log settings. However, I am not sure if PluginInterface.GeneralChatType is being used for a specific purpose and if using SystemMessage might break that.

Thanks! :D

— Reply to this email directly, view it on GitHub https://github.com/lmcintyre/OrchestrionPlugin/issues/35#issuecomment-1606129094, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN2FIJIPMFO5ZIXHH7JDKLXNBIX5ANCNFSM6AAAAAAZTGOTLE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lmcintyre commented 9 months ago

Hi! Sorry for leaving this hanging for so long. The update to Orchestrion with patch 6.5 will add the ability to sync the chat channel to the Dalamud setting, or set it separately.