search

lmcintyre / OrchestrionPlugin

Simple BGM management plugin for XivLauncher
MIT License
23 stars 28 forks source link

Mount / Combat modes not being accounted for with option selected #50

Open CerbStarraiser opened 8 months ago

CerbStarraiser commented 8 months ago

I think this problem started happening closer to the Endwalker release. I submitted a feedback item through Dalamud and wanted to be very patient with all the great work ya'll do, so I never poked since then. I wanted to bring it up again to see if it might be fixable.

Basically, once upon a time, the replacement feature accounted for mounts and combat--so if you mounted in a town, and had music replaced for the mount to none, it'd act as if the mount music wasn't playing, and if you leave town, it plays the proper field music. If you entered a fate, it would switch to the fate's music if unique, then back when you exited.

Now, if you mount in a town with replace to off, the town's music follows you as long as you're on the mount. If you're on a mount and enter a fate, you switch to the fate's music, and the fate music follows you as long as you're on the mount, regardless of whether you're in the fate or not.

I think I discussed this with perchbird once a long time ago when they initially implemented, so I think they understand the behavior that I'm looking for.

If I can provide more detail, please let me know. Cheers,

lmcintyre commented 8 months ago

I will leave this issue open and look into it when I have time. Thank you for the bug report. Unfortunately, the code for replacements is still quite messy and I would like to refactor again as well as add some features relating to replacements as well eventually.