lmcintyre / OrchestrionPlugin

Simple BGM management plugin for XivLauncher
MIT License
20 stars 25 forks source link

fix res #51

Closed uiharuayako closed 4 months ago

uiharuayako commented 4 months ago

First of all, thank you for your contribution to maintaining the plugins. In the 6.5 version update, the official Dalamud plugin repository for the Chinese server used your Git address for compilation. However, we found that in the .csproj file, only English, French, and Italian resource files seem to have been added. When Chinese server users use the orchestrion plugin and select Chinese as the UI language, the displayed interface remains in English. So, I've submitted a pull request to add localization files for other languages to the .csproj file. Additionally, due to some restrictions on the Chinese internet, many users cannot access Google Sheets. Therefore, I have stored a copy of the .csv file in the data folder. These changes are straightforward, and my pull request does not necessarily have to be merged. You can also add these resource files in your preferred way. Meanwhile, users from the Chinese plugin community have also translated the newly added songs (ID987-998 and ID20012-20021). The translation results are stored in the "zh" worksheet of this link (https://docs.google.com/spreadsheets/d/1f7OlI0xEcweXVvSKkqHMx_QVELY2tir3SZQXA6X_D3E/edit?usp=sharing). I hope you can add these new contents to your spreadsheet. Thank you! (Perhaps consider putting the song list on Crowdin as well? This might involve a considerable amount of work!)

lmcintyre commented 4 months ago

Thank you, I have added these changes manually to the latest release. I have updated the zh song list and included it in the plugin, as well as the missing zh localization file.

Unfortunately putting the song list on Crowdin would result in significantly more work, as every other language operates using comments on the Google Sheet.