search

lmcjt37 / curated-tv-and-film

A curated list of iconic TV and movie moments from modern filmography
https://lmcjt37.github.io/curated-tv-and-film/
MIT License
10 stars 52 forks source link

Curated-fevicon #250

Closed sowmiyeh closed 3 years ago

sowmiyeh commented 3 years ago

PR for issue #243

lmcjt37 commented 3 years ago

~There are 3 png format images to replace at /public/assets/~

~You should make sure they are like for like in name and size. I would expect there to be 3 file changes in this PR.~

~Example logo-16.png is the name and is 16x16~

Just looking into this and the file should actually be named favicon.ico and be 64x64. The other logo pngs can then be deleted in favour of this.

sowmiyeh commented 3 years ago

~There are 3 png format images to replace at /public/assets/~

~You should make sure they are like for like in name and size. I would expect there to be 3 file changes in this PR.~

~Example logo-16.png is the name and is 16x16~

Just looking into this and the file should actually be named favicon.ico and be 64x64. The other logo pngs can then be deleted in favour of this.

Please check it now @lmcjt37

lmcjt37 commented 3 years ago

Hi @sowmiya-venkatesan

Looks like the size is right.

But the file name should be favicon.ico without the .png format as this is a ico format file. Also need to remove the logo assets still.

sowmiyeh commented 3 years ago

Hi @sowmiya-venkatesan

Looks like the size is right.

But the file name should be favicon.ico without the .png format as this is a ico format file. Also need to remove the logo assets still.

Done with replacing logos also with correct format

sowmiyeh commented 3 years ago

Thanks for merging it, it would be great if you can label it as accepted

lmcjt37 commented 3 years ago

Please check your Hacktoberfest profile page as the merge should count towards your PR count.

sowmiyeh commented 3 years ago

Please check your Hacktoberfest profile page as the merge should count towards your PR count.

Yes it is, Thank you !!