lmcneil7 / teen-titans

project for digital humanities spring 2020 (a continuation from fall 2019 DH course)
2 stars 0 forks source link

Checkpoint 3 Website Review. #32

Closed BMT45 closed 3 years ago

BMT45 commented 4 years ago

@lmcneil7 @smdunn921 @amberpeddicord From what I've seen, your file structure for you GitHub repository for the teen titans is very well organized. I liked how you put each season in it's own folder but I would create a new folder that contains the issues of the comic book that relate to season 2 of the tv show in it's own folder when it comes to using Exide if applicable to your project.

You used a SSI to create the navigation bar of your site which is awesome. I was looking through your season 1 texts and would you be able to add a menu to allow viewers to click on specific episodes rather than just scrolling from them one by one to get to the episode along with the comic that relates to it if it has one. You could use this after mark up and putting up files for season 2. You don't have to do this but it's helpful for UX.

For the splash page for the maps, I would have some divs and classes to have a possible organizational structure to the eventual map page. I would also put a paragraph on there maybe to describe what might be on the map eventually and this could also change later down the line. I feel like this would save you sometime later and will help you get a better idea of what kind of data you would like to present on the map. The CSS sheet you use for the site also uses flex boxes well.

Great Job on Checkpoint 3! There were just some little organizational stuff you could do here and there along with some prep work you could for further construction of the site. Hope you guys keep up the great work!